Add big footer #142
Merged
Add big footer #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamahanna
reviewed
May 6, 2020
| {big && isExtendedNavLinks(links) && <ExtendedNav nestedLinks={links} />} | ||
|
|
||
| {!isExtendedNavLinks(links) && ( | ||
| <ul className="grid-row grid-gap"> |
There was a problem hiding this comment.
Just as a heads up, I created a list component that could be used here too. It's not merged in yet though, so 🤷
https://github.com/trussworks/react-uswds/blob/61535c9510d4d528f02b09aaaa45de8ff0ebd789/src/components/header/List/List.stories.tsx
eamahanna
reviewed
May 8, 2020
| parameters: { | ||
| info: ` | ||
| Used in USWDS 2.0 Footer component | ||
| Nav used in USWDS 2.0 Footer component. Can display simple nav items in a basic nav, or grouped nav items in an extended nav. |
There was a problem hiding this comment.
I think we should try and be consistent with our descriptions and either stick with saying what component it is used in first or the actual description of the component. The order of the footer and address component descriptions are not consistent. This is definitely just a nit. It's not really a big deal.
haworku
added a commit
that referenced
this pull request
May 11, 2020
* add ExtendedNav in FooterNav * add SignupForm and implement in Footer * Organize stories in subdirectories and add info
haworku
added a commit
that referenced
this pull request
May 11, 2020
* Add extended nav behavior inside FooterNav * Add SignupForm * Organize stories in subdirectories and add info
haworku
added a commit
that referenced
this pull request
May 19, 2020
* Add extended nav behavior inside FooterNav * Add SignupForm * Organize stories in subdirectories and add info
haworku
added a commit
that referenced
this pull request
May 22, 2020
* Add extended nav behavior inside FooterNav * Add SignupForm * Organize stories in subdirectories and add info
haworku
added a commit
that referenced
this pull request
May 22, 2020
suzubara
pushed a commit
that referenced
this pull request
May 22, 2020
* Add extended nav behavior inside FooterNav * Add SignupForm * Organize stories in subdirectories and add info
suzubara
pushed a commit
that referenced
this pull request
May 28, 2020
* Bump standard-version from 7.1.0 to 8.0.0 Bumps [standard-version](https://github.com/conventional-changelog/standard-version) from 7.1.0 to 8.0.0. - [Release notes](https://github.com/conventional-changelog/standard-version/releases) - [Changelog](https://github.com/conventional-changelog/standard-version/blob/master/CHANGELOG.md) - [Commits](conventional-changelog/standard-version@v7.1.0...v8.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Created issue templates Created issue templates for feature request & bug report, with default labels. * fix: removes the usa-search class name from the form component (#184) fix #163 * fix: accept id and name props for Search component input field (#183) * fix: accept id and name props for Search component input field * fix: qualify id and name props for input field to not clash with form fix #162 * feat: add dateInput component for forms (#144) * Added dateInput component and dateInputGroup component for forms * fix: extends header menu to accept list props for corresponding id (#188) fix #165 * fix: update gov banner to uswds version 2.7.0 * chore: upgrade uswds to 2.7.0 * docs: add documentation for Trussels (#190) * docs: add documentation for Trussels * docs: clean up readme to meet project standards * docs: add to active maintainers * docs: add first pass of security policy Co-authored-by: HANA <hana@truss.works> * feat: add Footer component #142 (#146) - adds slim, medium, and big footers with mobile styles - adds new components, specifically Address, Footer, FooterNav, FooterExtendedNavList, Logo, SocialLinks * build(deps-dev): bump @testing-library/jest-dom from 5.7.0 to 5.8.0 (#197) * build(deps-dev): bump typescript from 3.9.2 to 3.9.3 (#196) * build(deps-dev): bump @storybook/react from 5.3.18 to 5.3.19 (#198) * build(deps-dev): bump stylelint from 13.4.1 to 13.5.0 (#199) * build(deps-dev): bump lint-staged from 10.2.4 to 10.2.6 (#200) * build(deps-dev): bump @storybook/addon-info from 5.3.18 to 5.3.19 (#201) * feat(rangeinput): creates form RangeInput component, test, and stories (#194) * feat(rangeinput): creates form RangeInput component, test, and stories * feat: add RangeInput component to index.ts for entrypoint export * feat: remove overalpping interface props with HTMLInputAttributes type * feat: require id and name props, remove label, remove redundant unpack * feat: remove unused label import in component, show label usage in story fixes #81 * docs: add landing page and documentation page template stories (#195) * docs: add landing page and documentation page template stories * docs(storybook): add current class to header navigation * ci: lint PR titles instead of commits #159 (#210) * chore: add semantic pr workflow * chore: update workflow * Remove commitlint hook * Clarify PR linting requirement Co-authored-by: HANA <hana@truss.works> * chore(release): 1.4.0 * Remove duplicate entry from changelog Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Duncan <52669884+duncan-truss@users.noreply.github.com> Co-authored-by: Emily Mahanna <56279459+eamahanna@users.noreply.github.com> Co-authored-by: HANA <hana@truss.works>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete
<Footer />ExtendedNavbehavior toFooterNavSignupFormPR (3 of 3) for #78